[Role] az role assignment list: Add --fill-principal-name to allow skipping filling principalName property
#30693
+1,987
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| role assignment list | cmd role assignment list added parameter fill_principal_name |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az role assignment listDescription
Fix #30469 (comment)
After getting role assignments from REST API,
az role assignment listqueries Microsoft Graph to fill theprincipalNameproperty:userPrincipalNameServicePrincipalNames[0]displayNameThe motivation is to provide a display name of the assignee, but when the logged-in account has no permission,
az role assignment listwill show a warning:azure-cli/src/azure-cli/azure/cli/command_modules/role/custom.py
Line 300 in 4d6d480
To make things worse, if the machine has no network access to Microsoft Graph, the whole command will fail.
This PR adds
--fill-principal-nameargument to allow skipping fillingprincipalNameproperty.Testing Guide
Additional information
I deliberately choose
--fill-principal-nameinstead of--no-fill-principal-name, because this gives us the possibility to turn off fillingprincipalNameby default. If we choose--no-fill-principal-name, turning on fillingprincipalNamewill become--no-fill-principal-name falsewhich is awkward.