-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FullTextIndexes to IndexingPolicy and add FullTextPolicy to ContainerProperties #4816
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
public string Path { get; set; } | ||
|
||
/// <summary> | ||
/// Gets or sets a string containing the language of the full text path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a override for the container language?
#else | ||
internal | ||
#endif | ||
Collection<FullTextIndexPath> FullTextIndexes { get; set; } = new Collection<FullTextIndexPath>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests?
Thanks @changanhan . I am working on taking this forward from here. Will submit a fresh PR and once merged, I will close this. |
Thanks Debdatta.
From: Debdatta Kunda ***@***.***>
Sent: Friday, October 18, 2024 20:10
To: Azure/azure-cosmos-dotnet-v3 ***@***.***>
Cc: Changan Han ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/azure-cosmos-dotnet-v3] Add FullTextIndexes to IndexingPolicy and add FullTextPolicy to ContainerProperties (PR #4816)
Thanks @changanhan<https://github.com/changanhan> . I am working on taking this forward from here. Will submit a fresh PR and once merged, I will close this.
-
Reply to this email directly, view it on GitHub<#4816 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BH6LGA3AQUMBOFSZT72752TZ4GPPDAVCNFSM6AAAAABQEPFP72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGM4TGNRZGU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Add FullTextIndexes to IndexingPolicy and add FullTextPolicy to ContainerProperties
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber