Remove unnecessary package dependencies. #4899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
requested review from
kirankumarkolli,
FabianMeiswinkel,
sboshra and
Pilchie
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Note that removing these is a (very small) source breaking change. If some downstream consumer relied on the fact that we brought them in, they will have to update their own projects to reference these instead. Not saying we shouldn't do it, just that we should document it clearly in release notes, and not do it in a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR removes three package dependencies from the
Microsoft.Azure.Cosmosproject. These are very old packages and not needed when targeting .NET Standard 2.0+; in fact they bring in dozens of unnecessary transitive dependencies and significantly increase the total download size.Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber