Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networkalerts #474

Merged
merged 17 commits into from
Jan 10, 2025
Merged

Networkalerts #474

merged 17 commits into from
Jan 10, 2025

Conversation

tagolovina
Copy link
Contributor

@tagolovina tagolovina commented Jan 3, 2025

This PR adds and fixes:

  1. Adds Routes Delete Alert
  2. Adds Route Table Delete Alert
  3. Adds Management Groups Filtering in Portal Accelerator
  4. Fixes issue: [Feature Request] Provide monitoring and alerting guidance for route table entries #438

Breaking Changes

  1. No

As part of this Pull Request I have

  • [+] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [+] Checked for duplicate Pull Requests
  • [+] Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [+] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [+] Ensured PR tests are passing
  • [+] Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

image
image
image
image

  1. Routes Delete Alert
    image
    image
  2. Route Table Delete Alert
    image
    image

@tagolovina tagolovina closed this Jan 3, 2025
@tagolovina tagolovina reopened this Jan 3, 2025
@tagolovina tagolovina marked this pull request as ready for review January 3, 2025 19:27
@tagolovina tagolovina requested a review from Brunoga-MS January 3, 2025 19:28
Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagolovina : see the comments on the respective files and add the missing params to the param file. Better not use the existing activityUDRUpdatePolicyEffect and activityUDRUpdateAlertState in the new alerts. Let's create new ones

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagolovina : as per agreement during one of our Lead sync call, we need to put [Preview] in front of policies and alert names to set the correct expectations. I would change line 4

from:
"displayName": "Deploy Activity Log Routes Delete Alert",

To:
"displayName": "[Preview] Deploy Activity Log Routes Delete Alert",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tagolovina : no need to add the alerts here since this file is only kept for backward compatibility. We do not actively use it anymore since the former LandingZone policy was made modular.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@Brunoga-MS Brunoga-MS added the Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern label Jan 7, 2025
@tagolovina
Copy link
Contributor Author

tagolovina commented Jan 8, 2025

@Brunoga-MS , All changes have been made.

Copy link
Contributor

@Brunoga-MS Brunoga-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@Brunoga-MS Brunoga-MS merged commit 45a57be into Azure:main Jan 10, 2025
3 of 4 checks passed
@tagolovina tagolovina linked an issue Jan 10, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pattern: ALZ 🚁 Issues / PR's related to the ALZ Pattern
Projects
None yet
3 participants