-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networkalerts #474
Networkalerts #474
Conversation
…/routeTables/delete Microsoft.Network/routeTables/routes/delete Azure#438
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tagolovina : see the comments on the respective files and add the missing params to the param file. Better not use the existing activityUDRUpdatePolicyEffect and activityUDRUpdateAlertState in the new alerts. Let's create new ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tagolovina : as per agreement during one of our Lead sync call, we need to put [Preview] in front of policies and alert names to set the correct expectations. I would change line 4
from:
"displayName": "Deploy Activity Log Routes Delete Alert",
To:
"displayName": "[Preview] Deploy Activity Log Routes Delete Alert",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tagolovina : no need to add the alerts here since this file is only kept for backward compatibility. We do not actively use it anymore since the former LandingZone policy was made modular.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
…rting-LandingZone' associated with the policy definition '[Preview]_Deploy_activitylog_RouteTable_Delete' could not be validated
@Brunoga-MS , All changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
This PR adds and fixes:
Breaking Changes
As part of this Pull Request I have
main
branch