Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure Storage Queues README and Sample Issue #31257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Azure Storage Queues README and Sample Issue #31257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/storage/storage-blob/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ const { BlobServiceClient } = require("@azure/storage-blob");
const account = "<account name>";
const sas = "<service Shared Access Signature Token>";

const blobServiceClient = new BlobServiceClient(`https://${account}.blob.core.windows.net${sas}`);
const blobServiceClient = new BlobServiceClient(`https://${account}.blob.core.windows.net?${sas}`);
```

### Create a new container
Expand Down Expand Up @@ -476,7 +476,7 @@ const sas = "<service Shared Access Signature Token>";
const containerName = "<container name>";
const blobName = "<blob name>";

const blobServiceClient = new BlobServiceClient(`https://${account}.blob.core.windows.net${sas}`);
const blobServiceClient = new BlobServiceClient(`https://${account}.blob.core.windows.net?${sas}`);

async function main() {
const containerClient = blobServiceClient.getContainerClient(containerName);
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/samples/v12/javascript/advancedRequestOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async function main() {
});

const blobServiceClient = new BlobServiceClient(
`https://${account}.blob.core.windows.net${accountSas}`,
`https://${account}.blob.core.windows.net?${accountSas}`,
pipeline
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/samples/v12/javascript/anonymousAuth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ async function main() {
// List containers
const blobServiceClient = new BlobServiceClient(
// When using AnonymousCredential, following url should include a valid SAS or support public access
`https://${account}.blob.core.windows.net${accountSas}`,
`https://${account}.blob.core.windows.net?${accountSas}`,
new AnonymousCredential()
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/samples/v12/javascript/customizedClientHeaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ async function main() {
pipeline.factories.unshift(new RequestIDPolicyFactory("Prefix"));

const blobServiceClient = new BlobServiceClient(
`https://${account}.blob.core.windows.net${accountSas}`,
`https://${account}.blob.core.windows.net?${accountSas}`,
pipeline
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/samples/v12/typescript/src/advancedRequestOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async function main() {
});

const blobServiceClient = new BlobServiceClient(
`https://${account}.blob.core.windows.net${accountSas}`,
`https://${account}.blob.core.windows.net?${accountSas}`,
pipeline
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/samples/v12/typescript/src/anonymousAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ async function main() {
// List containers
const blobServiceClient = new BlobServiceClient(
// When using AnonymousCredential, following url should include a valid SAS or support public access
`https://${account}.blob.core.windows.net${accountSas}`,
`https://${account}.blob.core.windows.net?${accountSas}`,
new AnonymousCredential()
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-blob/samples/v12/typescript/src/customizedClientHeaders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ async function main() {
pipeline.factories.unshift(new RequestIDPolicyFactory("Prefix"));

const blobServiceClient = new BlobServiceClient(
`https://${account}.blob.core.windows.net${accountSas}`,
`https://${account}.blob.core.windows.net?${accountSas}`,
pipeline
);

Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-file-share/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ const account = "<account name>";
const sas = "<service Shared Access Signature Token>";

const serviceClientWithSAS = new ShareServiceClient(
`https://${account}.file.core.windows.net${sas}`
`https://${account}.file.core.windows.net?${sas}`
);
```

Expand Down Expand Up @@ -453,7 +453,7 @@ const sas = "<service Shared Access Signature Token>";
const shareName = "<share name>";
const fileName = "<file name>";

const serviceClient = new ShareServiceClient(`https://${account}.file.core.windows.net${sas}`);
const serviceClient = new ShareServiceClient(`https://${account}.file.core.windows.net?${sas}`);

async function main() {
const fileClient = serviceClient
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-share/samples/v12/javascript/advancedRequestOptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ async function main() {
});

const serviceClient = new ShareServiceClient(
`https://${account}.file.core.windows.net${accountSas}`,
`https://${account}.file.core.windows.net?${accountSas}`,
pipeline
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-share/samples/v12/javascript/anonymousAuth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ async function main() {
// List shares
const serviceClient = new ShareServiceClient(
// When using AnonymousCredential, following url should include a valid SAS
`https://${account}.file.core.windows.net${accountSas}`,
`https://${account}.file.core.windows.net?${accountSas}`,
anonymousCredential
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-share/samples/v12/typescript/src/advancedRequestOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export async function main() {
});

const serviceClient = new ShareServiceClient(
`https://${account}.file.core.windows.net${accountSas}`,
`https://${account}.file.core.windows.net?${accountSas}`,
pipeline
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-file-share/samples/v12/typescript/src/anonymousAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function main() {
// List shares
const serviceClient = new ShareServiceClient(
// When using AnonymousCredential, following url should include a valid SAS
`https://${account}.file.core.windows.net${accountSas}`,
`https://${account}.file.core.windows.net?${accountSas}`,
anonymousCredential
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-queue/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ const { QueueServiceClient } = require("@azure/storage-queue");
const account = "<account name>";
const sas = "<service Shared Access Signature Token>";
const queueServiceClient = new QueueServiceClient(
`https://${account}.queue.core.windows.net${sas}`
`https://${account}.queue.core.windows.net?${sas}`
);
```

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-queue/samples/v12/javascript/anonymousAuth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ async function main() {

const queueServiceClient = new QueueServiceClient(
// When using AnonymousCredential, following url should include a valid SAS or support public access
`https://${account}.queue.core.windows.net${accountSas}`,
`https://${account}.queue.core.windows.net?${accountSas}`,
anonymousCredential
);

Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/storage-queue/samples/v12/typescript/src/anonymousAuth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export async function main() {

const queueServiceClient = new QueueServiceClient(
// When using AnonymousCredential, following url should include a valid SAS or support public access
`https://${account}.queue.core.windows.net${accountSas}`,
`https://${account}.queue.core.windows.net?${accountSas}`,
anonymousCredential
);

Expand Down