JS sdk changes for merge support #31354
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjwalsoni1707
requested review from
amanrao23,
aditishree1,
sajeetharan and
topshot99
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
How about other operations like change feed etc. - do they work post merge without any changes? |
topshot99
reviewed
Oct 24, 2024
topshot99
reviewed
Oct 24, 2024
In other operations merge support is already handled |
amanrao23
requested changes
Dec 27, 2024
sdk/cosmosdb/cosmos/src/queryExecutionContext/parallelQueryExecutionContextBase.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/cosmos
Issues associated with this PR
#23417
Describe the problem that is addressed by this PR
Partition merge (preview) is one of feature in CosmosDB which allows us to reduce the number of physical partitions by merging them. With merge, containers that have low RU/s or storage per partition or storage can have their physical partition layout optimized for better performance. As of now this feature is not supported by the Node SDK and if the feature is enabled, all requests from Node SDK will be blocked. So, after this PR, Node SDK will support this feature.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists