[OpenAI] Structured output test & samples #31476
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
minhanh-phan
requested review from
ckairen,
jeremymeng,
a team,
glharper and
deyaaeldeen
as code owners
minhanh-phan
commented
Nov 20, 2024
| @@ -510,8 +555,29 @@ interface ChatCompletionTestOptions { | |||
| functions?: boolean; | |||
| allowEmptyStream?: boolean; | |||
| allowEmptyId?: boolean; | |||
| structuredOutput?: boolean; | |||
There was a problem hiding this comment.
Suggested change
| structuredOutput?: boolean; |
minhanh-phan
commented
Nov 20, 2024
| @@ -231,7 +276,7 @@ function assertContentFilterBlocklistIdResult(val: ContentFilterBlocklistIdResul | |||
|
|
|||
| function assertChoice( | |||
| choice: ChatCompletion.Choice | ChatCompletionChunk.Choice, | |||
| options: ChatCompletionTestOptions, | |||
| { ...options }: ChatCompletionTestOptions, | |||
There was a problem hiding this comment.
Suggested change
| { ...options }: ChatCompletionTestOptions, | |
| options: ChatCompletionTestOptions, |
minhanh-phan
commented
Nov 20, 2024
| } | ||
|
|
||
| interface EmbeddingTestOptions { | ||
| dimensions?: number; | ||
| } | ||
|
|
||
| // Structure output interfaces | ||
| export interface Step { |
There was a problem hiding this comment.
Refactor to another utils function since it is not universal
minhanh-phan
commented
Nov 20, 2024
| }); | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| matrix([[APIVersion.Preview]] as const, async function (apiVersion: APIVersion) { |
There was a problem hiding this comment.
remove matrix, use skip if for describe in vitest
… openai/structured-output
… openai/structured-output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add structured output samples and tests for AOAI