Full text Search functionality #31683

topshot99 · 2024-11-08T07:08:47Z

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:***(Applicable only to SDK release request PRs)*

Checklists

Added impacted package name to the issue description
Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
Added a changelog (if necessary)

### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]>

### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Ujjwal Soni <[email protected]>

### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]>

### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]> Co-authored-by: Ujjwal Soni <[email protected]>

sdk/cosmosdb/cosmos/src/queryIterator.ts

### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]> Co-authored-by: Ujjwal Soni <[email protected]>

sdk/cosmosdb/cosmos/review/cosmos.api.md

sdk/cosmosdb/cosmos/src/queryExecutionContext/hybridQueryExecutionContext.ts

amanrao23 · 2024-11-11T17:57:11Z

sdk/cosmosdb/cosmos/src/queryExecutionContext/hybridQueryExecutionContext.ts

+
+  private applySkipAndTakeToBuffer(): void {
+    const { skip, take } = this.partitionedQueryExecutionInfo.hybridSearchQueryInfo;
+    if (skip) {


Add checks for condition if skip or take are greater than buffer size. Add check if both skip and take are present, and take > skipped buffer size

amanrao23 · 2024-11-11T18:02:01Z

sdk/cosmosdb/cosmos/src/queryExecutionContext/hybridQueryExecutionContext.ts

+      await this.fetchMoreInternal(diagnosticNode, nextItemRespHeaders);
+    }
+
+    if (this.buffer.length > 0) {


add condition for draining and done here along with buffer length

amanrao23 · 2024-11-12T06:29:42Z

sdk/cosmosdb/cosmos/src/queryExecutionContext/hybridQueryExecutionContext.ts

+  ): QueryInfo[] {
+    return componentQueryInfos.map((queryInfo) => {
+      if (!queryInfo.hasNonStreamingOrderBy) {
+        throw new Error("The component query should a non streaming order by");


This error message could be improved.

### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]> Co-authored-by: Ujjwal Soni <[email protected]>

amanrao23 · 2024-11-14T20:05:03Z

sdk/cosmosdb/cosmos/test/public/integration/fullTextSearch.spec.ts

@@ -134,7 +259,7 @@ describe.skip("Validate full text search queries", function (this: Suite) {

  it("FetchNext: should return correct expected values for all the queries", async function () {
    for (const [query, { expected1, expected2 }] of queriesMap) {
-      const queryOptions = { allowUnboundedNonStreamingQueries: true };
+      const queryOptions = { allowUnboundedNonStreamingQueries: true, forceQueryOlan: true };


small typo, need to fix:
forceQueryOlan -> forceQueryPlan

### Packages impacted by this PR ### Issues associated with this PR ### Describe the problem that is addressed by this PR ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ ### Provide a list of related PRs _(if any)_ ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Manik Khandelwal <[email protected]> Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> Co-authored-by: Jeremy Meng <[email protected]> Co-authored-by: Matthew Podwysocki <[email protected]> Co-authored-by: Jackson Weber <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: chungshengfu <[email protected]> Co-authored-by: Chung Sheng Fu <[email protected]> Co-authored-by: Howie Leung <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: cqnguy23 <[email protected]> Co-authored-by: tomnguyen <[email protected]> Co-authored-by: Scott Beddall <[email protected]> Co-authored-by: Jeff Fisher <[email protected]> Co-authored-by: Maor Leger <[email protected]> Co-authored-by: Ujjwal Soni <[email protected]> Co-authored-by: ZiWei Chen <[email protected]> Co-authored-by: Minh-Anh Phan <[email protected]> Co-authored-by: Daniel Jurek <[email protected]> Co-authored-by: Albert Cheng <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Siddharth Singha Roy <[email protected]> Co-authored-by: Ben Broderick Phillips <[email protected]> Co-authored-by: Lazar <[email protected]> Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: hamshavathimunibyraiah <[email protected]> Co-authored-by: Juntu Chen <[email protected]> Co-authored-by: Wei Hu <[email protected]> Co-authored-by: angellan-msft <[email protected]> Co-authored-by: Kashish Gupta <[email protected]> Co-authored-by: Krista Pratico <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: Vansh Vardhan Singh <[email protected]> Co-authored-by: EmmaZhu-MSFT <[email protected]> Co-authored-by: guptakashish <[email protected]>

topshot99 and others added 8 commits October 30, 2024 17:50

topshot99 requested review from amanrao23, aditishree1 and sajeetharan as code owners November 8, 2024 07:08

github-actions bot added the Cosmos label Nov 8, 2024

topshot99 and others added 3 commits November 8, 2024 13:57

topshot99 requested review from bterlson and a team as code owners November 8, 2024 09:11

topshot99 and others added 4 commits November 8, 2024 15:35

topshot99 commented Nov 11, 2024

View reviewed changes

sdk/cosmosdb/cosmos/src/queryIterator.ts Show resolved Hide resolved

amanrao23 reviewed Nov 11, 2024

View reviewed changes

amanrao23 reviewed Nov 12, 2024

View reviewed changes

topshot99 and others added 2 commits November 13, 2024 09:37

amanrao23 reviewed Nov 14, 2024

View reviewed changes

topshot99 requested a review from qiaozha as a code owner November 18, 2024 11:35

topshot99 requested review from joshfree, pvaneck, KevinBlasko, scottaddie, ToddKingMSFT, jairmyree and Haiying-MSFT November 18, 2024 11:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full text Search functionality #31683

Full text Search functionality #31683

topshot99 commented Nov 8, 2024

amanrao23 Nov 11, 2024

topshot99 Nov 13, 2024

amanrao23 Nov 11, 2024

topshot99 Nov 13, 2024

amanrao23 Nov 12, 2024

topshot99 Nov 13, 2024

amanrao23 Nov 14, 2024

Full text Search functionality #31683

Are you sure you want to change the base?

Full text Search functionality #31683

Conversation

topshot99 commented Nov 8, 2024

Packages impacted by this PR

Issues associated with this PR

Describe the problem that is addressed by this PR

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

amanrao23 Nov 11, 2024

Choose a reason for hiding this comment

topshot99 Nov 13, 2024

Choose a reason for hiding this comment

amanrao23 Nov 11, 2024

Choose a reason for hiding this comment

topshot99 Nov 13, 2024

Choose a reason for hiding this comment

amanrao23 Nov 12, 2024

Choose a reason for hiding this comment

topshot99 Nov 13, 2024

Choose a reason for hiding this comment

amanrao23 Nov 14, 2024

Choose a reason for hiding this comment

Command used to generate this PR:***(Applicable only to SDK release request PRs)*