Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] : [@azure/cosmos] Add Full text search support for cosmos-explorer #31710
base: main
Are you sure you want to change the base?
[Do not merge] : [@azure/cosmos] Add Full text search support for cosmos-explorer #31710
Changes from 26 commits
360d332
8dc5356
46bd786
3e36c96
e799caf
1c4870c
f7d80ca
2a7f44d
dcbd5a4
6332df2
2d64ca9
aaf45f4
636e745
96647b5
b859b13
d4799a6
16c4ca4
26d0929
9c8cd6d
6a00339
3349ef2
82b2974
f348d4d
00f5aef
7ae8287
fa097e0
af72225
e46c167
28901d1
6457b0e
bd40fe2
c38f6d6
a9fc970
02f24b8
fa230a2
4bb6efa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FullTextSearchIndex, FullTextSearchPath, FullTextSearchPolicy might be clearer, just
fullText
doesn't tell me muchThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
ru
mean? Can we find a clearer name?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a well known concept for request units in the case of Cosmos DB https://learn.microsoft.com/en-us/azure/cosmos-db/request-units
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a bunch of shipped and new undocumented code - is that expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is a semaphore needed for synchronous operations? I thought JavaScript has run-to-completion semantics but maybe I missed something?