[keyvault-keys] Migrate to TypeSpec #31845
Conversation
maorleger
force-pushed
the
keyvault-keys-typespec
branch
from
007b6c8 to
70476dd
Compare
| @@ -0,0 +1,83 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
The end result is that this file should be deleted once all the workarounds are no longer needed
| /** ECDSA using P-521 and SHA-512, as described in https://tools.ietf.org/html/rfc7518 */ | ||
| ES512 = "ES512", | ||
| /** ECDSA using P-256K and SHA-256, as described in https://tools.ietf.org/html/rfc7518 */ | ||
| ES256K = "ES256K", |
There was a problem hiding this comment.
Generated incorrectly as ES256_K
| /** The NIST P-521 elliptic curve, AKA SECG curve SECP521R1. */ | ||
| P521 = "P-521", | ||
| /** The SECG SECP256K1 elliptic curve. */ | ||
| P256K = "P-256K", |
There was a problem hiding this comment.
Generated incorrectly as P256_K
There was a problem hiding this comment.
Cc @MaryGao -- this looks like another example of the enum normalization being different in Modular vs HLC (Azure/autorest.typescript#2832)
There was a problem hiding this comment.
Yes, this is an accepted breaking discussed here and we keep some special chars e.g underscore here between numbers or before/ending with numbers.
If you think the name here is not reasonable, you could use client name to rename.
@@clientName(JsonWebKeyCurveName.P256_K, "P256K", "javascript");
Also we are open to hear feedbacks for this breaking if you have any concern feel free to raise your concern in codegen issue.
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
maorleger
changed the title
maorleger
force-pushed
the
keyvault-keys-typespec
branch
from
3fa2212 to
29d03c9
Compare
| await client.listDeletedKeys(options).next(); | ||
| await client.listPropertiesOfKeys(options).next(); | ||
| await client.listPropertiesOfKeyVersions(keyName, options).next(); | ||
| // TODO: figure out tracing strategy for list operations |
There was a problem hiding this comment.
Still needs to be addressed, but it could be that we decide not to trace paged operation logical spans and just emit the http spans
| /** The NIST P-521 elliptic curve, AKA SECG curve SECP521R1. */ | ||
| P521 = "P-521", | ||
| /** The SECG SECP256K1 elliptic curve. */ | ||
| P256K = "P-256K", |
There was a problem hiding this comment.
Cc @MaryGao -- this looks like another example of the enum normalization being different in Modular vs HLC (Azure/autorest.typescript#2832)
maorleger
force-pushed
the
keyvault-keys-typespec
branch
3 times, most recently
from
65f5051 to
7812be2
Compare
maorleger
force-pushed
the
keyvault-keys-typespec
branch
from
7812be2 to
7858037
Compare
Packages impacted by this PR
@azure/keyvault-keys
Issues associated with this PR
Describe the problem that is addressed by this PR
Generates client using TypeSpec, with any workarounds scripted and noted
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR: (Applicable only to SDK release request PRs)
Checklists