[eslint-plugin] update regex of matching TypeScript file extentions #32571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our custom rules perform operations on TypeScript files only and they use a regex of `/\.ts$/.test(fileName)` to check whether a file is TypeScript code file or not. With the migration to ESM we now can have .mts and .cts files as well. This PR updates the pattern to also match those files.
There was a problem hiding this comment.
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (1)
- common/tools/eslint-plugin-azure-sdk/tests/fixture/tsconfig.json: Language not supported
deyaaeldeen
approved these changes
Jan 16, 2025
I searched but couldn't find other places of similar check. With just two and they are short and clear I'd keep them. If there is a third or more usage we can refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our custom rules perform operations on TypeScript files only and they use a regex of
/\.ts$/.test(fileName)to check whether a file is TypeScript code file or not. With the migration to ESM we can have .mts and .cts files as well. This PR updates the pattern to also match those files.Packages impacted by this PR
@azure/eslint-plugin-azure-sdk