[mgmt] migrate mgmt package to esm 13 #32598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazrael2119
requested review from
qiaozha,
MaryGao,
a team,
ckairen and
jeremymeng
as code owners
github-actions
bot
added
the
Mgmt
|
API change check API changes are not detected in this pull request. |
mpodwysocki
reviewed
Jan 17, 2025
| "@vitest/coverage-istanbul": "^2.1.8", | ||
| "dotenv": "^16.0.0", | ||
| "playwright": "^1.49.1", | ||
| "tsx": "^4.7.1", |
There was a problem hiding this comment.
We should probably remove tsx as well. Just a note for the future.
mpodwysocki
reviewed
Jan 17, 2025
| @@ -8,11 +8,11 @@ | |||
| "node": ">=18.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "@azure/core-lro": "^2.5.4", | |||
| "@azure/abort-controller": "^2.1.2", | |||
There was a problem hiding this comment.
We should also make sure we upgrade to @azure/abort-controller 2.1.2 if not done already. Many ARM packages are still on 1.0.0
mpodwysocki
reviewed
Jan 17, 2025
| @@ -33,7 +31,7 @@ async function createDnssecConfig() { | |||
| console.log(result); | |||
| } | |||
|
|
|||
| async function main() { | |||
| async function main(): Promise<void> { | |||
| createDnssecConfig(); | |||
There was a problem hiding this comment.
We should fix these functions because we're not awaiting the result of this so it could be an unhandled error should it throw.
mpodwysocki
approved these changes
Jan 17, 2025
|
@kazrael2119 I have a gist in which you could just do local patching using ts-morph to fix the await issues for the samples-dev as noted here: https://gist.github.com/mpodwysocki/216db5f4605cb3f972a0ae6fd45139c4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32184
@@azure/arm-dnsazure/arm-dns-profile-2020-09-01-hybrid