Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@azure/eventgrid-system-events] Update System events for Version 1.0.0-beta.5 #32602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sarangan12
Copy link
Member

Packages impacted by this PR

@azure/eventgrid-system-events

Issues associated with this PR

NA

Describe the problem that is addressed by this PR

This PR consists of the following changes:

  • Added internetMessageId property to AcsEmailDeliveryReportReceivedEventData.
  • Added recipientMailServerHostName property to AcsEmailDeliveryReportStatusDetails.
  • For AcsSmsReceivedEventData:
    • Added segmentCount property
  • Regenerated SDK with latest commit.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

There are no specific/complex design scenarios for this task.

Are there test cases added in this PR? (If not, why?)

No. This item is standard and we need not add test cases for every new events. The existing cases would be sufficient.

Provide a list of related PRs (if any)

#29688
#30627
#31188

Command used to generate this PR:**(Applicable only to SDK release request PRs)

npx tsp compile client.tsp

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@sarangan12 sarangan12 requested review from bterlson and a team as code owners January 17, 2025 15:17
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure/eventgrid-system-events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants