Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configs to use new TME tenant #37667

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Update configs to use new TME tenant #37667

merged 1 commit into from
Oct 7, 2024

Conversation

weshaggard
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@weshaggard weshaggard force-pushed the AddTMECloudConfig branch 2 times, most recently from 849e5f1 to 3fe7801 Compare October 1, 2024 17:53
@weshaggard
Copy link
Member Author

/azp run python - keyvault - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard weshaggard force-pushed the AddTMECloudConfig branch 2 times, most recently from b41b4fa to 4cc1d9f Compare October 1, 2024 18:18
@weshaggard
Copy link
Member Author

/azp run python - keyvault - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - keyvault - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - documentintelligence - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - keyvault - tests

@weshaggard weshaggard requested a review from scottaddie October 2, 2024 23:01
@weshaggard
Copy link
Member Author

/azp run python - monitor - tests

@weshaggard
Copy link
Member Author

/azp run python - identity - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - storage - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - search - tests

@weshaggard
Copy link
Member Author

/azp run python - storage - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - servicebus - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run python - keyvault - tests-weekly

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

benbp
benbp reviewed Oct 4, 2024
View reviewed changes
sdk/agrifood/tests.yml
@@ -8,6 +8,7 @@ extends:
Clouds: Public_FarmBeats
CloudConfig:
Public_Farmbeats:
ServiceConnection: azure-sdk-tests-public #Might need a specific service connection if this is a unique sub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard I checked and they are using a custom sub (5bae917c-5fc9-40c5-923d-adbd52759048). I don't have access though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think they care much about this pipeline currently as the existing client secret is also not working. So, either way they will need to spend time to fix this when they are interested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard what is the guidance for services that use a custom sub? Our openai tests use static resources from a non-SDK team owned sub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no general guidance. We need to look into them case by case.

benbp
benbp approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with the farmbeats caveat

@weshaggard
Update test configs to use new TME tenant
ca9255d 
- Update usgov and china configs to use default service connection
@weshaggard
Copy link
Member Author

@xiangyan99 @scbedd could you please review this PR? I'm not planning on blocking on all the test failures but I believe I have the test deployments working and individual teams will need to look at the test pipelines for failures. There may be some work needed enable things in the new TME sub but individual teams will need to work on that.

scbedd
scbedd approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Ignore farmbeats errors on merge.

pvaneck
pvaneck approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Monitor test pipeline failure is due to an unrelated issue.

@weshaggard weshaggard merged commit c759481 into Azure:main Oct 7, 2024
333 of 346 checks passed
@weshaggard weshaggard deleted the AddTMECloudConfig branch October 7, 2024 23:27
@mccoyp mccoyp mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@scbedd scbedd scbedd approved these changes

@mccoyp mccoyp mccoyp approved these changes

@pvaneck pvaneck pvaneck approved these changes

@benbp benbp benbp approved these changes

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312 YalinLi0312 is a code owner

@kristapratico kristapratico Awaiting requested review from kristapratico kristapratico is a code owner

@quentinRobinson quentinRobinson Awaiting requested review from quentinRobinson quentinRobinson is a code owner

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@kashifkhan kashifkhan Awaiting requested review from kashifkhan kashifkhan is a code owner

@swathipil swathipil Awaiting requested review from swathipil swathipil is a code owner

@l0lawrence l0lawrence Awaiting requested review from l0lawrence l0lawrence is a code owner

@glecaros glecaros Awaiting requested review from glecaros glecaros is a code owner

@tomsft tomsft Awaiting requested review from tomsft tomsft is a code owner

@koen-mertens koen-mertens Awaiting requested review from koen-mertens koen-mertens is a code owner

@AikoBB AikoBB Awaiting requested review from AikoBB AikoBB is a code owner

@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

@mjafferi-msft mjafferi-msft Awaiting requested review from mjafferi-msft mjafferi-msft is a code owner

@gfeitosa-msft gfeitosa-msft Awaiting requested review from gfeitosa-msft gfeitosa-msft is a code owner

@besh2014 besh2014 Awaiting requested review from besh2014 besh2014 is a code owner

@phermanov-msft phermanov-msft Awaiting requested review from phermanov-msft phermanov-msft is a code owner

@ilyapaliakou-msft ilyapaliakou-msft Awaiting requested review from ilyapaliakou-msft ilyapaliakou-msft is a code owner

@miguhern miguhern Awaiting requested review from miguhern miguhern is a code owner

@whisper6284 whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

@danielav7 danielav7 Awaiting requested review from danielav7 danielav7 is a code owner

@yogeshmo yogeshmo Awaiting requested review from yogeshmo yogeshmo is a code owner

@LuChen-Microsoft LuChen-Microsoft Awaiting requested review from LuChen-Microsoft LuChen-Microsoft is a code owner

@jalauzon-msft jalauzon-msft Awaiting requested review from jalauzon-msft jalauzon-msft is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

@weirongw23-msft weirongw23-msft Awaiting requested review from weirongw23-msft weirongw23-msft is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@scottaddie scottaddie Awaiting requested review from scottaddie scottaddie is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Document Intelligence KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@weshaggard @xiangyan99 @azure-sdk @benbp @pvaneck @kristapratico @mccoyp @scbedd