Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#129 To-Sidebar 개선 cause of the problem
If the height is less than 800px when accessing the site, 'affix class' (postion: fixed) is assigned to the sidebar.
azure-sdk-korean/js/customscripts.js
Lines 8 to 12 in ed54ddb
If the width is less than 990px, the 'position: relative' property is assigned to the sidebar.
azure-sdk-korean/css/customstyles.css
Lines 1036 to 1053 in ed54ddb
Lines 1036 to 1053 in ed54ddb
If 'afiix Class' is not assigned (height > 800) and the width is over 990px, postion is not specified. See the screen below
Therefore, it was modified so that the affix class is assigned in all conditions.
Compare
Before
After
#129 To-Sidebar 개선 문제 원인
사이트 접속시 height가 800이하일 경우 sidebar에 'affix' class가(postion : fixed) 부여됨.
azure-sdk-korean/js/customscripts.js
Lines 8 to 12 in ed54ddb
width가 990px 이하일 경우 sidebar에 position : relative 속성이 부여됨.
azure-sdk-korean/css/customstyles.css
Lines 1036 to 1053 in ed54ddb
afiix Class가 부여되지 않고(height > 800) width가 990px 이상일 경우 postion이 따로 지정되지 않아 아래와 같이 보임.
따라서 모든 조건에서 affix class이 할당되도록 수정하였습니다.
비교해보세요.
변경전
변경후