feat: Enable skip of CI deployment tests #4203
Draft
+246
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
6 tasks
ReneHezser
added
Type: CI 🚀
eriqua
reviewed
Jan 17, 2025
| @@ -213,7 +213,39 @@ runs: | |||
|
|
|||
| # [Deployment validation] task(s) | |||
| # ------------------------------- | |||
| - name: "Validate Test Execution" | |||
There was a problem hiding this comment.
Wondering if we could skip the whole job instead of singular steps
eriqua
reviewed
Jan 17, 2025
| @@ -180,3 +180,4 @@ | |||
| /avm/res/web/static-site/ @Azure/avm-res-web-staticsite-module-owners-bicep @Azure/avm-module-reviewers-bicep | |||
| /avm/utl/types/avm-common-types/ @Azure/avm-utl-types-avmcommontypes-module-owners-bicep @Azure/avm-module-reviewers-bicep | |||
| *avm.core.team.tests.ps1 @Azure/avm-core-team-technical-bicep | |||
| *.e2eignore @Azure/avm-core-team-technical-bicep | |||
There was a problem hiding this comment.
Looking forward to discussing, great work meanwhile!
The main suggestion I'd have for now is to add tests. At least one pipeline run with one deployment test skipped and one base case pipeline with no test skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow testcases to be excluded from deplyoments by the CI deployment.
Azure/Azure-Verified-Modules#1796
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.