feat: Multiple postinstall symlinks pointing to the same thing #495
+322
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow for multiple links to point to the same target. Signed-off-by: Peter Engelbert <[email protected]>
Signed-off-by: Peter Engelbert <[email protected]>
cpuguy83
reviewed
Jan 10, 2025
| @@ -130,7 +130,8 @@ type PostInstall struct { | |||
| // SymlinkTarget specifies the properties of a symlink | |||
| type SymlinkTarget struct { | |||
| // Path is the path where the symlink should be placed | |||
| Path string `yaml:"path" json:"path" jsonschema:"required"` | |||
| Path string `yaml:"path" json:"path" jsonschema:"oneof_required=path"` | |||
There was a problem hiding this comment.
We should mark this is deprecated and have people use paths instead.
We can also make it so when we load the spec we migrate Path to Paths then there's only one field to deal with.
There was a problem hiding this comment.
How do we mark it as deprecated?
cpuguy83
requested changes
Jan 10, 2025
| @@ -42,6 +42,12 @@ func (t *Target) validate() error { | |||
| } | |||
| } | |||
|
|
|||
| if t.Image != nil { | |||
There was a problem hiding this comment.
Let's add a validate to t.Image, which itself could return nil if *Image is nil (note: this is what I did in #492
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, you can't create multiple symlink
newpaths that point to the sameoldpath. This is due to the fact that map keys have to be unique.For more information, see #489
This should be merged before #494