Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quoted table names #2473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thomasfroehle
Copy link

Why make this change?

What is this change?

How was this tested?

  • Integration Tests -> I'm happy to extend the integration tests, if this fix seems like a good idea
  • Unit Tests
  • manually

Sample Request(s)

Sample configuraiton:

"MyTable": {
  "source": {
    "object": "schema.\"MyTable\"",
    "type": "table"
  }
}

@thomasfroehle thomasfroehle changed the title Supports quoted table names Support quoted table names Nov 24, 2024
@abhishekkumams
Copy link
Contributor

Thanks @thomasfroehle , would you be able to add some unit tests inside the file: SqlMetadataProviderUnitTests.cs ?

@abhishekkumams
Copy link
Contributor

/azp run

@abhishekkumams abhishekkumams added the bug Something isn't working label Nov 25, 2024
@Aniruddh25
Copy link
Contributor

/azp run

Copy link
Contributor

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, consider adding tests either in this or follow up PR if this is getting stale.

@thomasfroehle
Copy link
Author

I'll add some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Quoted Table name are not supported
3 participants