interface: improve ClusterStagedUpdateRun APIs #1008
+114
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiying-lin
reviewed
Jan 7, 2025
jwtty
force-pushed
the
stagerun-apiexample
branch
2 times, most recently
from
e0058dc to
e4822b7
Compare
jwtty
changed the title
zhiying-lin
reviewed
Jan 9, 2025
| @@ -17,6 +17,13 @@ import ( | |||
| // +kubebuilder:subresource:status | |||
| // +kubebuilder:resource:scope=Cluster,categories={fleet,fleet-placement},shortName=crsur | |||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
| // +kubebuilder:printcolumn:JSONPath=`.spec.placementName`,name="Placement",type=string | |||
| // +kubebuilder:printcolumn:JSONPath=`.spec.resourceSnapshotIndex`,name="ResourceSnapshot",type=string | |||
There was a problem hiding this comment.
have a question about this field.
we want an index or a name? from the example you provided, it's a name.
The resources could be divided to multiple snapshots.
There was a problem hiding this comment.
It's the name. And we have a validation that only the master snapshot name should be provided.
There was a problem hiding this comment.
Then we need to rename the spec field as discussed
1 task
jwtty
force-pushed
the
stagerun-apiexample
branch
from
b5d3d56 to
5e0e36d
Compare
jwtty
changed the title
| // +kubebuilder:printcolumn:JSONPath=`.status.conditions[?(@.type=="Succeeded")].status`,name="Succeeded",type=string | ||
| // +kubebuilder:printcolumn:JSONPath=`.metadata.creationTimestamp`,name="Age",type=date | ||
| // +kubebuilder:printcolumn:JSONPath=`.spec.stagedRolloutStrategyName`,name="Strategy",priority=1,type=string | ||
| // +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 128",message="metadata.name max length is 127" |
There was a problem hiding this comment.
we need a test for this, similiar to test/apis/placement/v1beta1/api_validation_integration_test.go
| @@ -102,7 +110,7 @@ type ClusterStagedUpdateStrategyList struct { | |||
| type StageConfig struct { | |||
| // The name of the stage. This MUST be unique within the same StagedUpdateStrategy. | |||
| // +kubebuilder:validation:MaxLength=63 | |||
| // +kubebuilder:validation:Pattern="[A-Za-z0-9]+$" | |||
| // +kubebuilder:validation:Pattern="^[a-z0-9]+$" | |||
There was a problem hiding this comment.
I wonder why we only allow lower case for stage name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
clusterStagedUpdateRunandclusterApprovalRequestobjects.The
getcommand outputs now look like:Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer