Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helmcli] Add support to show debug log #74

Closed
wants to merge 1 commit into from
Closed

[helmcli] Add support to show debug log #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/kperf/commands/runnergroup/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,8 @@
statusCommand,
},
}

// debuLog function to log messages using klog.
func debugLog(level klog.Level, format string, args ...interface{}) {

Check failure on line 31 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / linter 

undefined: klog

Check failure on line 31 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / linter 

undefined: klog

Check failure on line 31 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / test 

undefined: klog

Check failure on line 31 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / build 

undefined: klog
Copy link
Author

@PugDeveloper PugDeveloper Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you put the function in the root? and would it be like this?

klog.V(level).Infof(format, args...)

Check failure on line 32 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / linter 

undefined: klog (typecheck)

Check failure on line 32 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / linter 

undefined: klog) (typecheck)

Check failure on line 32 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / test 

undefined: klog

Check failure on line 32 in cmd/kperf/commands/runnergroup/root.go

View workflow job for this annotation

GitHub Actions / build 

undefined: klog
}
1 change: 1 addition & 0 deletions cmd/kperf/commands/runnergroup/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ var runCommand = cli.Command{
}

kubeCfgPath := cliCtx.GlobalString("kubeconfig")

return runner.CreateRunnerGroupServer(context.Background(),
kubeCfgPath,
imgRef,
Expand Down
Loading