Restore detail in weidu completion. Fixes #8

BGforgeNet · May 27, 2019 · fbbdf56 · fbbdf56
1 parent 27abbcf
commit fbbdf56
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -20,3 +20,6 @@
 
 ## 1.0.5
 - More IE constants supported.
+
+## 1.0.6
+- Fixed detail missing from weidu completion
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
 	"name": "bgforge-mls",
 	"displayName": "BGforge MLS",
 	"description": "BGforge multilanguage server",
-	"version": "1.0.5",
+	"version": "1.0.6",
 	"author": "BGforge",
 	"repository": {
 		"type": "git",

diff --git a/server/src/server.ts b/server/src/server.ts
@@ -219,15 +219,12 @@ function load_completion() {
 			for (item in completion_yaml) {
 				let kind = parseInt(completion_yaml[item]['type']);
 				let element: any;
-				let dtl: string;
+				let detail: string;
+				let doc: string;
 				for (element of completion_yaml[item]['items']) {
-					if (!element['detail']) { // copy name to detail if it's empty
-						element['detail'] = element['name'];
-					}
-					if (!element['doc']) { // allow empty doc, too
-						element['doc'] = '';
-					}
-					completion_list.push({ label: element['name'], kind: kind, documentation: element['doc'], detail: dtl, source: "builtin" });
+					detail = element['detail'] || element['name']; // copy name to detail if it's empty
+					doc = element['doc'] || ''; // allow empty doc, too
+					completion_list.push({ label: element['name'], kind: kind, documentation: doc, detail: detail, source: "builtin" });
 				}
 			}
 			completion_map.set(lang_id, completion_list);