Don’t render a picture if there is no img src

BKWLD · Nov 20, 2024 · f368cb5 · f368cb5
1 parent aafae1f
commit f368cb5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/contentful/src/lib/urlBuilding.ts b/packages/contentful/src/lib/urlBuilding.ts
@@ -13,6 +13,9 @@ export const defaultImageLoader: ImageLoader = ({
     src.portraitImage.url :
     src.image?.url || src.url
 
+  // If no URL found, return nothing
+  if (!url) return ''
+
   // Make Contentful resizing instructions
   const query = new URLSearchParams({ w: String(width) })
 

diff --git a/packages/react/src/PictureImage.tsx b/packages/react/src/PictureImage.tsx
@@ -47,6 +47,7 @@ export default function PictureImage(props: PictureImageProps): ReactNode {
 
   // Make the img src url
   const srcUrl = makeSrcUrl(src, imageLoader)
+  if (!srcUrl) return null
 
   // Make array or props that will be used to make <source>s.  A `null` type is
   // always added to create fallback sources for native mime-type of the