-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make admin reset "a little easier" #442
base: master
Are you sure you want to change the base?
The head ref may contain hidden characters: "make-admin-reset-\"a-little-easier\""
Make admin reset "a little easier" #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a check at line 1180 to ensure the percentage is below 100. While it would theorically work, better avoid unecessary code and logic, and skip straight to the "delete everything" case.
i will check later not home rn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.
Co-authored-by: Auguste Charpentier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
ballsdex/packages/admin/cog.py:1158
- The condition 'if not percentage or percentage == 100:' is ambiguous. It should explicitly check for 'percentage is None' or 'percentage == 0' instead of 'not percentage'.
if not percentage or percentage == 100:
ballsdex/packages/admin/cog.py:1160
- [nitpick] The message 'Are you sure you want to delete all {user}'s {settings.plural_collectible_name}?' should be clearer. Consider changing it to 'Are you sure you want to delete 100% of {user}'s {settings.plural_collectible_name}?'
f"Are you sure you want to delete all {user}'s {settings.plural_collectible_name}?"
No description provided.