Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make admin reset "a little easier" #442

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MaxxMXSZ
Copy link
Contributor

No description provided.

@MaxxMXSZ MaxxMXSZ added the package:admin All /admin commands and its configuration options label Oct 12, 2024
Copy link
Member

@laggron42 laggron42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a check at line 1180 to ensure the percentage is below 100. While it would theorically work, better avoid unecessary code and logic, and skip straight to the "delete everything" case.

ballsdex/packages/admin/cog.py Outdated Show resolved Hide resolved
@MaxxMXSZ
Copy link
Contributor Author

i will check later not home rn

@Kowlin Kowlin requested a review from Copilot November 20, 2024 22:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.

ballsdex/packages/admin/cog.py Outdated Show resolved Hide resolved
Co-authored-by: Auguste Charpentier <[email protected]>
@flaree flaree requested a review from Copilot December 11, 2024 14:08

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

ballsdex/packages/admin/cog.py:1158

  • The condition 'if not percentage or percentage == 100:' is ambiguous. It should explicitly check for 'percentage is None' or 'percentage == 0' instead of 'not percentage'.
if not percentage or percentage == 100:

ballsdex/packages/admin/cog.py:1160

  • [nitpick] The message 'Are you sure you want to delete all {user}'s {settings.plural_collectible_name}?' should be clearer. Consider changing it to 'Are you sure you want to delete 100% of {user}'s {settings.plural_collectible_name}?'
f"Are you sure you want to delete all {user}'s {settings.plural_collectible_name}?"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:admin All /admin commands and its configuration options
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants