fix issue #61, remove registerNodesIntoFactory #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarqRazz as correctly pointed out in issue #61 , we can not invoke a virtual method in the constructor.
This leaves only 2 possibilities:
execute
method.registerNodesIntoFactory
method and expose the factory in the public API.I propose solution 2, because my gut feeling is that solution 1 might be error-prone.
This unfortunately remove the ability of the factory to be "reset" if the list of folders changes at run-time, but that is something that is probably unlikely, anyway.
Now, the recommended place to do registration of custom node (or enum, we forgot that!) is the constructor of the derived class.
What do you think?