Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GetMapInfo from EventRecordCallback in CallBacks.c #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

remove GetMapInfo from EventRecordCallback in CallBacks.c #1

wants to merge 3 commits into from

Conversation

TsXor
Copy link

@TsXor TsXor commented Aug 11, 2023

The original GetMapInfo will left EventMapInfo in the stack of EventRecordCallback unchanged.
This fix changes the passing method of EventMapInfo from value to pointer.

@TsXor
Copy link
Author

TsXor commented Aug 11, 2023 •
edited
Loading

So sorry but I didn't notice my fix will make it unable to print out event userdata property values on my previous test.

@TsXor
Copy link
Author

TsXor commented Aug 11, 2023 •
edited
Loading

But I found something funny: the code can work normally if I replace EventMapInfo with NULL in the call to TdhFormatProperty.
It seems that my fix did what @Biswa96 originally want to do, which causes error.
Is this that famous "this program works thanks to bugs"?

@TsXor TsXor changed the title fix GetMapInfo in CallBacks.c remove GetMapInfo from EventRecordCallback in CallBacks.c Aug 11, 2023
@TsXor
fix SecHost.c L296: InstanceName can be NULL
8f9407a 
also: fix typo of InstanceName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TsXor