-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/implement config base and config config #12 #26
Fix/implement config base and config config #12 #26
Conversation
@gerceboss @star-gazer111 Review pls |
@18aaddy why is the CI build check failing here? It should've worked fine from this PR & onwards. |
@18aaddy , |
@gerceboss @star-gazer111 there was some issue with two imports in checkpoints/checkpoints.go CI build is still failing because of consensus/database.go as the functions have not been implemented yet. |
fine, the build check should run fine once we have this resolved. |
should we merge then or wait for the other PR first @star-gazer111 ? |
We can merge this once someone has reviewed the PR. I haven't done that, can you please do that |
Resolves #12