Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/implement config base and config config #12 #26

Conversation

18aaddy
Copy link

@18aaddy 18aaddy commented Aug 31, 2024

Resolves #12

  • Implemented config/config.go and config/base.go
  • Implemented tests for config.go and base.go (Tests successfully passing)
  • Also modified some errors in config/networks.go

@18aaddy
Copy link
Author

18aaddy commented Aug 31, 2024

@gerceboss @star-gazer111 Review pls

@star-gazer111
Copy link
Member

@18aaddy why is the CI build check failing here? It should've worked fine from this PR & onwards.

@gerceboss
Copy link
Contributor

@18aaddy , go get github.com/avast/retry-go ,some packages are not present either or they can't be added check locally as well.

@18aaddy
Copy link
Author

18aaddy commented Sep 1, 2024

@gerceboss @star-gazer111 there was some issue with two imports in checkpoints/checkpoints.go
I added the libraries using go get github.com/avast/retry-go gopkg.in/yaml.v2 which fixes it.

CI build is still failing because of consensus/database.go as the functions have not been implemented yet.

@star-gazer111
Copy link
Member

@gerceboss @star-gazer111 there was some issue with two imports in checkpoints/checkpoints.go I added the libraries using go get github.com/avast/retry-go gopkg.in/yaml.v2 which fixes it.

CI build is still failing because of consensus/database.go as the functions have not been implemented yet.

fine, the build check should run fine once we have this resolved.

@gerceboss
Copy link
Contributor

should we merge then or wait for the other PR first @star-gazer111 ?

@star-gazer111
Copy link
Member

should we merge then or wait for the other PR first @star-gazer111 ?

We can merge this once someone has reviewed the PR. I haven't done that, can you please do that

@gerceboss gerceboss merged commit 4c39cf1 into BlocSoc-iitr:dev Sep 14, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants