Implemented state.go and types.go #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeerChaurasia
force-pushed
the
Implement-Execution/state.go-execution/types.go-#23
branch
from
748d941 to
75dcc6c
Compare
execution/types.go
Outdated
Comment on lines
25
to
51
| func (c *CallOpts) MarshalJSON() ([]byte, error) { | ||
| type Alias CallOpts | ||
| return json.Marshal(&struct { | ||
| *Alias | ||
| Data string `json:"data,omitempty"` | ||
| }{ | ||
| Alias: (*Alias)(c), | ||
| Data: hex.EncodeToString(c.Data), | ||
| }) | ||
| } | ||
| func (c *CallOpts) UnmarshalJSON(data []byte) error { | ||
| type Alias CallOpts | ||
| aux := &struct { | ||
| *Alias | ||
| Data string `json:"data,omitempty"` | ||
| }{ | ||
| Alias: (*Alias)(c), | ||
| } | ||
| if err := json.Unmarshal(data, &aux); err != nil { | ||
| return err | ||
| } | ||
| decodedData, err := hex.DecodeString(aux.Data) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| c.Data = decodedData | ||
| return nil |
There was a problem hiding this comment.
Ok.actually the pr was opened before the refactoring.I will do the changes by today.
|
@VeerChaurasia Please make the changes by today , as the tests are failing without defined structs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Execution/state.go and types.go ,the linter workflow is working perfectly when the structs are defined perfectly.