Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mapping process + Cardano mapping info #137

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

LadyChristina
Copy link
Member

@LadyChristina LadyChristina commented Dec 11, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing documentation?
  • Have you verified that there aren't any other open Pull Requests for the same update/change?
  • Does the Pull Request pass all tests?

Description

Updated Cardano cluster information, so that it uses (unique) pool hashes as keys.
Also updated Cardano identifier processing, so that it doesn't store duplicate tickers (which can lead to false attribution)
In the process, I also made some improvements to the mapping classes, so that the mapping method is reported more accurately (now the options are 'known_identifiers', 'known_addresses', 'known_clusters', 'known_legal_links', 'fallback_mapping') and updated the documentation and tests accordingly.

Note that the reason why I changed some values in the end_to_end test is because of the additional cluster info we now have on Cardano, which changes the distribution of blocks to entities (now there is one entity that produces two blocks in the sample file). In general, I believe the tests shouldn't be based on these files, but this is sth we can address in the future.

Resolves #135

Checklist

Update Mapping Support Information Submissions:

  • For which ledger do you update the mapping information?
    • Cardano
  • What mapping information do you update?
    • identifiers
    • addresses
    • clusters
    • legal links
  • Did you update the tests (if needed)?

Copy link
Member

@dimkarakostas dimkarakostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - fix the nit and merge

mapping_information/clusters/test.json Outdated Show resolved Hide resolved
@LadyChristina LadyChristina merged commit 0b7e276 into main Dec 14, 2023
1 check passed
@LadyChristina LadyChristina deleted the cardano_pool_data branch December 14, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pool Clustering for Cardano is inaccurate due to methodology
2 participants