Corrections for mint-005.md (still incomplete) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes reflect my understanding of the rest of this document's statements, tables, miniscript policy and output descriptor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #14
This pull request includes 3 separate changes to the
mint-005.mdtemplate:Text corrections to the "Motivation" section which better represent the rest of the document's statements, tables, and Miniscript descriptor.
Commenting-out of sample transactions, as they do not appear to be from this same mint (timestamps are not all the same or in order). I'd expect to add another commit as soon as I've learned of sample transactions that better represent this mint -- as well as adjusting the timestamps in the document to match the samples.
Commenting-out of the Source Policy, which is temporary until I better understand the difference between identity wrappers (
sln:vssnl:) aroundafter(timestamp). I'd expect to revert this commit as soon as it's confirmed that it makes no difference and there isn't another source policy that compiles precisely to the same Miniscript in the descriptor.