Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: Fix CI and add Fedora target #17

Closed
wants to merge 3 commits into from

Conversation

Conan-Kudo
Copy link

This fixes the GitHub Actions configuration so that Alpine CI works and adds a Fedora Rawhide CI target to ensure a glibc target is included.

@Conan-Kudo Conan-Kudo marked this pull request as ready for review November 12, 2023 15:40
@Conan-Kudo Conan-Kudo requested review from serebit and a team as code owners November 12, 2023 15:40
@Conan-Kudo Conan-Kudo force-pushed the v1-fix-ci branch 3 times, most recently from 85175b9 to 032d08f Compare November 12, 2023 15:49
Copy link
Member

@serebit serebit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the checkout action for Alpine to complete.

This fixes the build so that it can download wlroots from git and build it.
This ensures we have a constantly fresh glibc-based target.
@serebit
Copy link
Member

serebit commented Nov 16, 2023

I fixed Alpine in v1, so this is gonna need a rebase.

@serebit
Copy link
Member

serebit commented Nov 17, 2023

Ended up just taking your changes and building on top of them. You're still marked as the author for your commits. Closing.

@serebit serebit closed this Nov 17, 2023
@Conan-Kudo Conan-Kudo deleted the v1-fix-ci branch November 17, 2023 04:34
@Conan-Kudo
Copy link
Author

No worries, thanks! Sorry I didn't get to your feedback in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants