Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/portal] Adding provision to configure liveness and readiness probe of all analytics containers #224

Open
wants to merge 4 commits into
base: develop/portal
Choose a base branch
from

Conversation

ksaladi
Copy link
Contributor

@ksaladi ksaladi commented Jun 20, 2023

Description of the change

  • Allowing the configuration of readiness and liveness params for all the analytics containers
  • Adding the param to the nginx controller to support upload size limits upto 32MB

Benefits

  • Will allow adding suitable readiness and liveness values for specific envs(esp SaaS)

Drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [charts/gateway])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

…d to provide additional time for SaaS deployment
@ksaladi ksaladi changed the base branch from stable to develop/portal June 20, 2023 15:23
Copy link
Contributor

@APIM-KiranVaddadi APIM-KiranVaddadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the same for all analytics containers including initialDelaySeconds, timeoutSeconds, periodSeconds, success and failure threshold.

        initialDelaySeconds: {{ .Values.historical.readinessProbe.initialDelaySeconds }}
        periodSeconds: {{ .Values.historical.readinessProbe.periodSeconds }}
        timeoutSeconds: {{ .Values.historical.readinessProbe.timeoutSeconds }}
        failureThreshold: {{ .Values.historical.readinessProbe.failureThreshold }}
        successThreshold: {{ .Values.historical.readinessProbe.successThreshold }}

…ytics containers and adding the param to the nginx controller to support size limits upto 32MB
@ksaladi ksaladi changed the title [charts/portal] Adding provision to configure liveness and readiness probe value of historical [charts/portal] Adding provision to configure liveness and readiness probe of all analytics containers Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants