Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE594909-1: update IDLECONNECTIONTESTPERIOD default values for in README #307

Open
wants to merge 18 commits into
base: develop/portal
Choose a base branch
from
Open

DE594909-1: update IDLECONNECTIONTESTPERIOD default values for in README #307

wants to merge 18 commits into from

Conversation

gdeol77
Copy link
Contributor

@gdeol77 gdeol77 commented Apr 16, 2024

Description of the change

Benefits

Drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • [] Chart version bumped in Chart.yaml according to semver.
  • [] Variables are documented in the README.md
  • [] Title of the PR starts with chart name (e.g. [charts/gateway])
  • [] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

kiran vaddadi and others added 18 commits February 23, 2024 12:24
otk patch
2c54036
otk patch
99329ec
otk patch
96560dd
otk patch
4a6c044
update tag name
b770340
@Gazza7205
Merge pull request #296 from CAAPIM/kv664763_otk_patch
677c8f1 
[charts/gateway] OTK JWT patch release
Merge branch 'stable' of https://github.com/CAAPIM/apim-charts into k…
424ce02 
…s_p523_merge
@Gazza7205
Merge pull request #301 from CAAPIM/ks_p523_merge
6a22458 
[Charts/portal] Changes to support Portal version 5.2.3
@Gazza7205
added custom initContainer and sidecar volumes
d3c78ae
@Gazza7205
updated pmtagger container name
b85803c
@burbanski
Merge pull request #302 from CAAPIM/custom_volumes_ic_sc
90013b3 
charts/gateway added customInit and Sidecar volumes
Add configurable job history limits
93a648c
update readme
2d29006
fix hook annotation indentation
a52f106
@Gazza7205
Merge pull request #303 from CAAPIM/otk_job_history
2725bb4 
[charts/gateway] OTK db maintenance schedule job history
@Gazza7205
charts/gateway various updates
88ac851
@Gazza7205
Merge pull request #305 from CAAPIM/gateway_0424
5de94a4 
charts/gateway various updates
@gdeol77
DE594909-1: update IDLECONNECTIONTESTPERIOD default values
202af13
@gdeol77
Copy link
Contributor Author

gdeol77 commented Apr 16, 2024

RALLY: https://rally1.rallydev.com/#/102027125372d/iterationstatus?detail=%2Fdefect%2F755820166521%2Fdetails

@Gazza7205 Gazza7205 self-requested a review April 16, 2024 17:45
Gazza7205
Gazza7205 requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@Gazza7205 Gazza7205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increment the Portal Chart version in Chart.yaml

Also looks like you have additionalEvn in a few places - should that be additionalEnv?

@gdeol77 gdeol77 changed the base branch from stable to develop/portal April 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gazza7205 Gazza7205 Gazza7205 requested changes

@acheuk acheuk Awaiting requested review from acheuk

@meetyourdev meetyourdev Awaiting requested review from meetyourdev

@markgxchen markgxchen Awaiting requested review from markgxchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdeol77 @Gazza7205 @burbanski