Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16141] Implement ReceiverEnrichment Function #16854

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

wcutshall
Copy link
Collaborator

@wcutshall wcutshall commented Dec 19, 2024

This PR introduces a new step into the ReportStream pipeline. Receiver Enrichment relocates the enrichment schema functionality from FHIRTranslator to the new FHIRReceiverEnrichment step.

Test Steps:

  1. Observe the transforms in resources/metadata/fhir_transforms/receivers/fhir-message-header-sample.yml.
  2. Run the pipeline locally (../gradlew quickRun)
  3. Start with a clean environment (../gradlew clearDB, ../gradlew reloadSettings, ../gradlew reloadTables).
  4. Choose a message from the Postman collection (e.g., Single HL7 Full ELR) and post it to the running application.
  5. In the Azure Storage Explorer find the resulting file in the blob container and download it for inspection.
  6. Search the file for the values from step 1.

Changes

  • You can view all the file changes here.
  • Changes include modifications to existing code to move the receiver enrichment code out of the translate step of the pipeline to a new step, schema changes to the database (which must be included with this PR in order for jOOQ to be able to build DAO classes from the schema), and updates to documentation.

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • No linked issues.

To Be Done

  • No TBD items.

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • No new application endpoints, but a new Azure function
      • elr-fhir-receiver-enrichment
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
    • No.
  • Does this change introduce new dependencies that need vetting?
    • No.
  • Does this change require changes to our infrastructure?
    • No.
  • Does logging contain sensitive data?
    • No.
  • Does this PR include or remove any sensitive information itself?
    • No.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results

1 275 tests  +3   1 271 ✅ +3   7m 25s ⏱️ -15s
  167 suites +2       4 💤 ±0 
  167 files   +2       0 ❌ ±0 

Results for commit 4cfa997. ± Comparison against base commit 1e0e737.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.
gov.cdc.prime.router.fhirengine.engine.FhirTranslatorTests ‑ test receiver enrichment()
gov.cdc.prime.router.fhirengine.azure.FHIRReceiverEnrichmentIntegrationTests ‑ successfully add enrichments()
gov.cdc.prime.router.fhirengine.engine.FHIRReceiverEnrichmentTests ‑ fail - invalid message type()
gov.cdc.prime.router.fhirengine.engine.FHIRReceiverEnrichmentTests ‑ fail - missing receiver full name()
gov.cdc.prime.router.fhirengine.engine.FHIRReceiverEnrichmentTests ‑ test receiver enrichment()

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Integration Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4cfa997.

♻️ This comment has been updated with latest results.

@wcutshall wcutshall marked this pull request as ready for review January 24, 2025 19:45
@wcutshall wcutshall requested a review from a team as a code owner January 24, 2025 19:45
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants