Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1주차] 김동혁 미션 제출합니다. #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[1주차] 김동혁 미션 제출합니다. #2

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3744f29
feat: :sparkles: todo리스트 디자인 및 틀 설정
ddhelop Mar 11, 2024
1c1d7ff
feat: todoList 항목추가, 삭제, 완료 기능 구현
ddhelop Mar 12, 2024
316c6a7
test: 배포 테스트
ddhelop Mar 12, 2024
b54ecd5
feat: 할 일 삭제 시 애니메이션 추가
ddhelop Mar 13, 2024
95ffb1a
fix: '추가' 버튼 크기 조정
ddhelop Mar 13, 2024
f5d4b19
fix: 할일 체크 시 로컬스토리지에 저장되지 않는 버그 수정
ddhelop Mar 13, 2024
0266528
feat: 모바일(768px이하) 스타일
ddhelop Mar 14, 2024
daf9717
fix: 폰트 크기 조정
ddhelop Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ body {
background-color: #252423;
}
h1 {
font-size: 18px;
font-size: 1.125rem;
color: #e9ecef;
font-weight: 500;
margin: 0;
Expand Down Expand Up @@ -77,7 +77,7 @@ h1 {
}

#todayDate {
font-size: 10px;
font-size: 0.625rem;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모든 단위를 rem형식 혹은 px단위로 통일했었는데 font-size만 rem형식으로 바꿔주신 걸 보고 이렇게 사용할 수도 있구나 배웠어요!

color: gray;
margin: 6px 0 0 1px;
}
Expand Down Expand Up @@ -137,7 +137,7 @@ h1 {
width: 36px;
height: 22px;
border-radius: 10px;
font-size: 12px;
font-size: 0.75rem;
color: #788bff;
}
.submitBtn:hover {
Expand All @@ -153,7 +153,7 @@ h1 {
width: 100%;
height: 52px;
border-radius: 10px;
font-size: 13px;
font-size: 0.81rem;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷 2024-03-17 오전 4 42 11

이렇게 쓸 일은 잘 없겠지만 ㅎㅎ 혹시 모를 경우를 방지하기 위해
word-break : break-all;
추가해주셔도 좋을 것 같습니다~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오.. 이런 오류가 있었군요. 리팩토링하면서 수정해볼게요. 감사합니다~!

display: flex;
justify-content: space-between;
Expand All @@ -168,6 +168,7 @@ h1 {
.todoList li span {
width: 100%;
padding: 0px 26.1px;
font-size: 0.73rem;
}

.todoList li input {
Expand All @@ -182,7 +183,7 @@ h1 {
width: 36px;
height: 22px;
border-radius: 10px;
font-size: 12px;
font-size: 0.75rem;
color: #788bff;
}
.todoList li button:hover {
Expand All @@ -198,11 +199,6 @@ h1 {

.header {
padding-left: 20px;
font-size: 1rem;
}

.title {
font-size: 16px;
}

.WriteForm,
Expand Down