Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcommand fallthrough #1073

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Subcommand fallthrough #1073

merged 9 commits into from
Oct 9, 2024

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 7, 2024

Add modifier for subcommands to restrict subcommands falling through to parent.
This will resolve #1022

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4ee3af) to head (881a843).
Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1073     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           17        17             
  Lines         4546      4688    +142     
  Branches         0      1007   +1007     
===========================================
+ Hits          4546      4688    +142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phlptp phlptp requested a review from henryiii October 7, 2024 20:02
@phlptp
Copy link
Collaborator Author

phlptp commented Oct 8, 2024

This also fixes some of the cmake build jobs that were failing from a recent update in that github action.

@phlptp
Copy link
Collaborator Author

phlptp commented Oct 8, 2024

Unless I hear some objections/suggestions I will merge this tomorrow morning.

@phlptp phlptp merged commit ca66827 into CLIUtils:main Oct 9, 2024
57 checks passed
@phlptp phlptp deleted the subcommand_fallthrough branch October 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Positional is treated as a sub-command
2 participants