update macros for codecvt and support C++26 support on clang19 #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 17 17
Lines 4546 5034 +488
Branches 0 1029 +1029
===========================================
+ Hits 4546 5034 +488 ☔ View full report in Codecov by Sentry. |
henryiii
approved these changes
Jan 3, 2025
|
Please see #1113 and specifically 9a2884a where I fix the build error on LLVM 19 with C++26 after rooting the actual template issue (see #1098 (comment)) |
phlptp
added a commit
that referenced
this pull request
Jan 11, 2025
* Modifies #1100 * That PR comes from https://github.com/phlptp/CLI11 and unfortunately I have no way of opening a PR to that repo, pointing to that branch... The commit you care about is 9a2884a @phlptp where I fix the build error on LLVM 19 with C++26 after rooting the actual template issue (see #1098 (comment)) It comes down to C++26 adding a tuple interface to std::complex https://en.cppreference.com/w/cpp/numeric/complex/tuple_size --------- Co-authored-by: Philip Top <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check updated macros for C++26 and llvm 19 support
specifically codecvt from issue #1098