Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing spaces on strings for conversions #1115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jan 13, 2025

Allow trailing spaces on strings for conversions to floating point and integers.

There was a potential confusing error that could occur if strings with trailing spaces were converted to integer or floating point values. This PR allows trailing spaces in the strings that would otherwise be convertible to the appropriate numerical type.

@phlptp phlptp added the bug label Jan 13, 2025
@phlptp
Copy link
Collaborator Author

phlptp commented Jan 13, 2025

Fixes #1094

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4ee3af) to head (e2dbad5).
Report is 64 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #1115     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           17        17             
  Lines         4546      5042    +496     
  Branches         0      1033   +1033     
===========================================
+ Hits          4546      5042    +496     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phlptp phlptp requested a review from henryiii January 14, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants