Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Merge JS binding module for the API #3

Merged
merged 3 commits into from
Oct 3, 2019
Merged

Merge JS binding module for the API #3

merged 3 commits into from
Oct 3, 2019

Conversation

sampsapenna
Copy link
Member

@sampsapenna sampsapenna commented Oct 3, 2019 •
edited
Loading

Description

Add JS bindings for the API to enable easier usage in applications.

Type of change

  • New feature (non-breaking change which adds functionality)

Changes Made

  • Write JS bindings module.
  • Add some debug logging to ease development.

Testing

@sampsapenna sampsapenna requested a review from blankdots October 3, 2019 12:03
@sampsapenna sampsapenna self-assigned this Oct 3, 2019
blankdots
blankdots reviewed Oct 3, 2019
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uvloop might be needed in requirements.txt

blankdots
blankdots approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the uvloop LGTM.
Demo would be nice when done 🙂

@sampsapenna sampsapenna merged commit b64a7c9 into devel Oct 3, 2019
@sampsapenna sampsapenna deleted the feature/js-bindings branch October 3, 2019 13:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blankdots blankdots blankdots approved these changes

Assignees

@sampsapenna sampsapenna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sampsapenna @blankdots