#2920 Properly handle flow abruption in ternary condition

plugin/core/src/main/java/com/perl5/lang/perl/idea/codeInsight/controlFlow/PerlControlFlowBuilder.java

@@ -675,7 +675,9 @@ public void visitTernaryExpr(@NotNull PsiPerlTernaryExpr o) {
       }
       children[0].accept(this);
       Instruction conditionInstruction = prevInstruction;
-      startConditionalNode(o, children[0], true);
+      if (conditionInstruction != null) {
+        startConditionalNode(o, children[0], true);
+      }
       children[1].accept(this);
       Instruction trueInstruction = prevInstruction;
       prevInstruction = conditionInstruction;

plugin/src/test/java/unit/perl/PerlControlFlowTest.java

@@ -26,6 +26,9 @@ protected String getBaseDataPath() {
     return "unit/perl/controlFlow";
   }
 
+  @Test
+  public void testTernaryDieCondition() { doTest(); }
+
   @Test
   public void testCheckOrDie() { doTest(); }
 

plugin/src/test/resources/annotator/perl/unreachableCode/ternaryDieCondition.code

@@ -1 +1 @@
-die("some") <error descr="Unreachable code">?</error> "one"<error descr="Unreachable code">:</error> "<error descr="Unreachable code">Two</error>";
+die("some") ? "<error descr="Unreachable code">one</error>": "<error descr="Unreachable code">Two</error>";

plugin/src/test/resources/unit/perl/controlFlow/ternaryDieCondition.code

@@ -0,0 +1 @@
+die("some") ? "one": "Two";

plugin/src/test/resources/unit/perl/controlFlow/ternaryDieCondition.pl.txt

@@ -0,0 +1,7 @@
+0(1) element: null (InstructionImpl)
+1(2) element: Perl5 (InstructionImpl)
+2(3) element: PsiPerlStringDqImpl(Perl5: STRING_DQ) (InstructionImpl)
+3(6) element: PsiPerlSubCallImpl(SUB_CALL) (PerlNoResultInstruction)
+4(6) element: PsiPerlStringDqImpl(Perl5: STRING_DQ) (InstructionImpl)
+5(6) element: PsiPerlStringDqImpl(Perl5: STRING_DQ) (InstructionImpl)
+6() element: null (InstructionImpl)

plugin/src/testFixtures/java/base/PerlLightTestCaseBase.java

@@ -1873,10 +1873,10 @@ private void saveSvgFile(final @NotNull String outSvgFile, final @NotNull Instru
         }
         case PartialConditionalInstructionImpl partialConditionalInstruction ->
           builder.append("\n").append("Its ").append(partialConditionalInstruction.getResult()).
-            append(" branch, condition: ").append(partialConditionalInstruction.getConditionText());
+            append(" branch, condition: ").append(escape(partialConditionalInstruction.getConditionText()));
         case ConditionalInstruction conditionalInstruction ->
           builder.append("\n").append("Its ").append(conditionalInstruction.getResult()).
-            append(" branch, condition: ").append(getTextSafe(conditionalInstruction.getCondition()));
+            append(" branch, condition: ").append(escape(getTextSafe(conditionalInstruction.getCondition())));
         default -> {
         }
       }