Hurricup/bugfixes 2 #2922
Merged
Hurricup/bugfixes 2 #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those fields are implicitly written by gson
Also fixed bounds
Qodana for JVM3489 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Detected 11 dependenciesThird-party software listThis page lists the third-party software dependencies used in perl5
Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -111,7 +112,7 @@ | |||
| } | |||
|
|
|||
| public static void reindexProjectFile(Project project, VirtualFile virtualFile) { | |||
| if (VfsUtil.isAncestor(project.getBaseDir(), virtualFile, false)) { | |||
| if (VfsUtilCore.isAncestor(project.getBaseDir(), virtualFile, false)) { | |||
Check warning
Code scanning / QDJVM
Deprecated API usage Warning
| PerlCallObjectValue value = (PerlCallObjectValue)o; | ||
|
|
||
| return mySuperContext != null ? mySuperContext.equals(value.mySuperContext) : value.mySuperContext == null; | ||
| return mySuperContext != null ? mySuperContext.equals(callObjectValue.mySuperContext) : callObjectValue.mySuperContext == null; |
Check notice
Code scanning / QDJVM
'equals()' expression replaceable by 'Objects.equals()' expression Note
| PerlValueResolver resolver = (PerlValueResolver)o; | ||
|
|
||
| if (!myResolveScope.equals(resolver.myResolveScope)) { | ||
| if (!myResolveScope.equals(((PerlValueResolver)o).myResolveScope)) { |
Check warning
Code scanning / QDJVM
Pattern variable can be used Warning
| return false; | ||
| } | ||
| return Objects.equals(myContextFile, resolver.myContextFile); | ||
| return Objects.equals(myContextFile, ((PerlValueResolver)o).myContextFile); |
Check warning
Code scanning / QDJVM
Pattern variable can be used Warning
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code style and modernization