A0-4591: Added major sync metric back (although by different name) #1919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings back major syncing metric that was unwillingly removed in 14 release. It copies some code from
polkadot-sdk
(metric definition), copy is required since we want different name andMajorSyncingGauge
constructor is private inpolkadot-sdk
. Other than that implementation approach is taken from thepolkadot-sdk
- theAtomicBool
is passed from its creation down to when it's used in the metric gauge.Type of change
Please delete options that are not relevant.
Testing
I run locally
./scripts/run_nodes.sh -v 4
, then immediately run `watch -n -1 ' curl localhost:9616/metrics | grep major_sync' is one console and in the otherand I saw correlation when the log appeared, the metric switched its state accordingly.