Fix for PointCloudShading.normalShading parameter

CHANGES.md

@@ -1,5 +1,7 @@
 # Change Log
 
+- Fixed the PointCloudShading.normalShading parameter. Now it disables shading using normals if point cloud contains normals, but the parameter is set to false. [#12066]
+
 ### 1.123 - 2024-11-01
 
 #### @cesium/engine

packages/engine/Source/Scene/Model/MaterialPipelineStage.js

@@ -140,9 +140,21 @@ MaterialPipelineStage.process = function (
     VertexAttributeSemantic.NORMAL,
   );
 
+  //Disable normals if PointCloud has them, but the parameter is set
+  //to false in PointCloudShading.normalShading.
+  let hasNormalsDisabling = false;
+  if (defined(model.pointCloudShading)) {
+    hasNormalsDisabling = !model.pointCloudShading.normalShading;
+  }
+
   // Classification models will be rendered as unlit.
   const lightingOptions = renderResources.lightingOptions;
-  if (material.unlit || !hasNormals || hasClassification) {
+  if (
+    material.unlit ||
+    !hasNormals ||
+    hasClassification ||
+    hasNormalsDisabling
+  ) {
     lightingOptions.lightingModel = LightingModel.UNLIT;
   } else {
     lightingOptions.lightingModel = LightingModel.PBR;