feat: remove redundant param for writeTextToCanvas

[ibreathebsb]

Description

This pull request removes redundant parameter textBaseline which is not used in writeTextToCanvas

Author checklist

• I have submitted a Contributor License Agreement
• I have added my name to CONTRIBUTORS.md
• I have updated CHANGES.md with a short summary of my change (no need acutally)
• I have added or updated unit tests to ensure consistent code coverage
• I have updated the inline documentation, and included code examples where relevant
• I have performed a self-review of my code

[github-actions]

Thank you for the pull request, @ibreathebsb!

✅ We can confirm we have a CLA on file for you.

[javagl]

For me, it looks like this can indeed safely be removed.

There are some broader issues with that function, though - just as cross-references: #9767 , #11747 , ...

[ggetz]

Thanks for the cleanup @ibreathebsb!

@jjspace Could you please take a review pass on this PR?

[jjspace]

You are correct that that option is unused. I was curious why and whether it should be used and found this old comment in a previous rewrite of this function #9765 (comment) that removed the place it was used.

I think this is good to go. Please merge in main to fix the conflicts.
It looks like you skipped running prettier somehow. please run npm run prettier and also make sure the pre-commit git hook is set up correctly.

[ibreathebsb]

You are correct that that option is unused. I was curious why and whether it should be used and found this old comment in a previous rewrite of this function #9765 (comment) that removed the place it was used.

I think this is good to go. Please merge in main to fix the conflicts. It looks like you skipped running prettier somehow. please run npm run prettier and also make sure the pre-commit git hook is set up correctly.

I have fixed prettier and git hooks issues,resolved conflicts

[jjspace]

Thanks for the changes @ibreathebsb, this looks good to go now.

The release tests in CI keep failing on the npm install step with what looks like connection issues. I'm currently assuming this might be something weird on Github's side so I'm gonna give it some time and try re-running them later and then hopefully it will be good to merge.