refactor: update snappy frame decompress #7333
Merged
+115
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7333 +/- ##
============================================
+ Coverage 48.75% 48.76% +0.01%
============================================
Files 601 601
Lines 40222 40243 +21
Branches 2061 2067 +6
============================================
+ Hits 19609 19626 +17
- Misses 20575 20579 +4
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
previously requested changes
Jan 7, 2025
Comment on lines
49
to
62
| case ChunkType.COMPRESSED: | ||
| case ChunkType.UNCOMPRESSED: { | ||
| const checksum = frame.subarray(0, 4); | ||
| const data = frame.subarray(4); | ||
|
|
||
| if (type === ChunkType.COMPRESSED) { | ||
| result.append(uncompress(data.subarray(4))); | ||
| } | ||
| if (type === ChunkType.UNCOMPRESSED) { | ||
| result.append(data.subarray(4)); | ||
| const uncompressed = type === ChunkType.COMPRESSED ? uncompress(data, UNCOMPRESSED_CHUNK_SIZE) : data; | ||
| if (uncompressed.length > UNCOMPRESSED_CHUNK_SIZE) { | ||
| throw "malformed input: too large"; | ||
| } | ||
| if (crc(uncompressed).compare(checksum) !== 0) { | ||
| throw "malformed input: bad checksum"; | ||
| } | ||
| result.append(uncompressed); | ||
| } |
There was a problem hiding this comment.
I would prefer to not mix ChunkType.COMPRESSED and ChunkType.UNCOMPRESSED logic in one case.
matthewkeil
approved these changes
Jan 8, 2025
| chunks.append(Uint8Array.from([ChunkType.UNCOMPRESSED, 0x80, 0x00, 0x00])); | ||
| // first 4 bytes are checksum | ||
| // 0xffffffff is clearly an invalid checksum | ||
| chunks.append(Uint8Array.from(Array.from({length: 0x80}, () => 0xff))); |
There was a problem hiding this comment.
why not use 128 here? Guessing this is a snappy spec thing but curious none-the-less
Suggested change
| chunks.append(Uint8Array.from(Array.from({length: 0x80}, () => 0xff))); | |
| chunks.append(Uint8Array.from(Array.from({length: 128}, () => 0xff))); |
There was a problem hiding this comment.
just an artifact from a test case I had been provided, there's nothing special about 128.
|
🎉 This PR is included in v1.25.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description