Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip light client data_collection spec tests #7349

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jan 10, 2025

Need to disable those for now to pass spec tests until #7348 is implemented. This is not a electra / devnet-5 specific change but was included v1.5.0-beta.0 spec release.

@nflaig nflaig requested a review from a team as a code owner January 10, 2025 12:19
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.61%. Comparing base (4d271ff) to head (d793115).
Report is 2 commits behind head on devnet-5.

Additional details and impacted files
@@            Coverage Diff            @@
##           devnet-5    #7349   +/-   ##
=========================================
  Coverage     48.61%   48.61%           
=========================================
  Files           603      603           
  Lines         40534    40534           
  Branches       2071     2071           
=========================================
  Hits          19707    19707           
  Misses        20789    20789           
  Partials         38       38           

@nflaig nflaig merged commit 3ea46e2 into devnet-5 Jan 13, 2025
15 of 17 checks passed
@nflaig nflaig deleted the nflaig/skip-lc-data-collection-tests branch January 13, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant