Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST-39230 refactor improved-scan-report sections to map from scan-report #705

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

cx-joses
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description
Changed sections mapping for improved-scan-report to match scan-report and simply translate for new sections

References
https://checkmarx.atlassian.net/browse/AST-39230

Testing
Manual and unit tests

Checklist
All active GitHub checks for tests, formatting, and security are passing
The correct base branch is being used

@github-actions github-actions bot added the bug Something isn't working label Apr 11, 2024
@pedrompflopes pedrompflopes requested a review from a team April 11, 2024 14:40
Copy link

github-actions bot commented Apr 11, 2024

Logo
Checkmarx One – Scan Summary & Details88160c11-f922-4c90-97c2-a37b6a001764

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@cx-joses cx-joses force-pushed the bug/AST-39230-translate-sections branch from 08f4dde to d5527e0 Compare April 11, 2024 14:49
Copy link
Contributor

@OrShamirCM OrShamirCM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to understand whats done here. Please explain the BL

@OrShamirCM OrShamirCM enabled auto-merge (squash) April 15, 2024 15:31
@OrShamirCM OrShamirCM disabled auto-merge April 16, 2024 10:15
@OrShamirCM OrShamirCM merged commit cee4a75 into main Apr 16, 2024
8 checks passed
@OrShamirCM OrShamirCM deleted the bug/AST-39230-translate-sections branch April 16, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants