Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kobih/exit code command #711

Conversation

checkmarx-kobi-hagmi
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

checkmarx-kobi-hagmi and others added 28 commits April 18, 2024 13:44
* fix redirect mechanism

* check

* check

* add const error variables

---------

Co-authored-by: AlvoBen <[email protected]>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.4...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
* add threshold user input check

* add threshold validation before running the scan

* added tests

* improve error msgs

* fix linter problems

* resolve conversation

* fix linter problems
---------

Co-authored-by: AlvoBen <[email protected]>
* SAP Application association Issue - Workaround

* SAP Application association Issue - Workaround

* Change Group Logic

* Update wait to polling application

* lint

* lint

* Update test

* Update test
…om/stretchr/testify-1.9.0

Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* test

* Update release.yml

* Update release.yml

* Update release.yml

* Update release.yml

* Update release.yml

---------

Co-authored-by: tamarleviCm <[email protected]>
* Bump github.com/stretchr/testify from 1.8.4 to 1.9.0

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.4...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update release.yml

* Add Makefile

* Update README.md

* brew services start docker

* remove flag

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: checkmarx-kobi-hagmi <[email protected]>
Co-authored-by: Noam Brendel <[email protected]>
* Fix project association polling issue (AST-40286)

* Update integration tests timeout to have more 2 min for polling logic

* Add sleep 2 sec between polling

* Fix application API

* fix lint, have sleep for 1 sec

* have longer timeout for tests (+2 min)

* have longer timeout for tests (+4 min)

* return error if timeout

* fix application mock
remove path

Co-authored-by: Noam Brendel <[email protected]>
* Fix project association polling issue (AST-40286)

* Update integration tests timeout to have more 2 min for polling logic

* Add sleep 2 sec between polling

* Fix application API

* fix lint, have sleep for 1 sec

* have longer timeout for tests (+2 min)

* have longer timeout for tests (+4 min)

* return error if timeout

* fix application mock

* delete duplicate test

* open pr

---------

Co-authored-by: tamarleviCm <[email protected]>
@OrShamirCM OrShamirCM closed this May 6, 2024
@OrShamirCM OrShamirCM deleted the feature/kobih/exit-code-command branch May 6, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants