Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SCS Vulnerabilities in json report when Agent is VSCode/AST-CLI (AST-63907) #850 #853

Merged
merged 17 commits into from
Sep 12, 2024

Conversation

sarahCx
Copy link
Contributor

@sarahCx sarahCx commented Aug 29, 2024

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Added full support for SCS engine results when scanning from the CLI.
Added partial support (only Secret Detection results) when scanning is done from VS Code
No other case SCS results are supported

References

https://checkmarx.atlassian.net/browse/AST-63907

Testing

Adding unit tests to test the following scenarios:
Scan from CLI - expect to receive all SCS engine results.
Scan from VS Code - expect to get only Secret Detection results.
Scan from another engine - expect to get no results from the SCS engine.
Scan without results from SCS.
Scan with NULL results.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@OrShamirCM OrShamirCM requested a review from a team August 29, 2024 10:11
Copy link

github-actions bot commented Aug 29, 2024

Logo
Checkmarx One – Scan Summary & Detailsa6f7d084-c462-43aa-a963-38c5d50a0cb4

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

internal/commands/result.go Outdated Show resolved Hide resolved
internal/wrappers/mock/results-mock.go Show resolved Hide resolved
AlvoBen
AlvoBen previously approved these changes Sep 3, 2024
@sarahCx sarahCx merged commit 8ece440 into main Sep 12, 2024
9 checks passed
@sarahCx sarahCx deleted the Feature/SupportScsResults branch September 12, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants