Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper cleanup of temporary ZIP files (AST-42950) #984

Merged
merged 6 commits into from
Dec 26, 2024

Conversation

elchananarb
Copy link
Contributor

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

https://checkmarx.atlassian.net/browse/AST-42950

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@github-actions github-actions bot added bug Something isn't working fix labels Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Logo
Checkmarx One – Scan Summary & Detailsc843a555-19b6-45f7-a9c1-85caeffd6930

No New Or Fixed Issues Found

miryamfoiferCX
miryamfoiferCX previously approved these changes Dec 26, 2024
internal/commands/scan.go Outdated Show resolved Hide resolved
@elchananarb elchananarb merged commit 2fc507b into main Dec 26, 2024
9 checks passed
@elchananarb elchananarb deleted the fix/elchanan/temp_zip_cleanup branch December 26, 2024 11:20
@elchananarb elchananarb restored the fix/elchanan/temp_zip_cleanup branch January 2, 2025 16:37
@elchananarb elchananarb deleted the fix/elchanan/temp_zip_cleanup branch January 2, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants