Skip to content

Commit

Permalink
Revert node version requirement
Browse files Browse the repository at this point in the history
  • Loading branch information
@ChiaMineJP @seeden
ChiaMineJP authored and seeden committed Dec 10, 2021
1 parent c9f4313 commit 6dfbc2d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/gui/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"homepage": "./",
"main": "build/electron/main.js",
"engines": {
"node": ">=16"
"node": ">=12.20.0"
},
"scripts": {
"start": "npm run electron",
Expand Down

2 comments on commit 6dfbc2d

@mlvl36667
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this necessary?

@ChiaMineJP
Copy link
Contributor Author

@ChiaMineJP ChiaMineJP commented on 6dfbc2d Jan 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #598

There was an issue where GitHub Action kept failing because of incompatible npm version.
I thought the issue came from old nodejs version, but turned out that issue was on old npm version.

Since I haven't understood how deep you know this issue, I cannot be sure whether my comment is sufficient to you.

Please sign in to comment.